Initial Android cross-compiler - #43535
Conversation
…K in the NewSFX subset.
…nuget packaging projects.
…-unified-sharedfx
… from the runtime.
This reverts commit 0587cba.
|
Green with correct nupkgs on internal https://dev.azure.com/dnceng/internal/_build/results?buildId=950402&view=results |
|
None of the remaining tests are related to stuff I've touched (and the one failure isn't my fault). Anything more to add, @vargaz @safern @ViktorHofer @akoeplinger ? |
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
Looks great, left a couple comments but nothing that should hold off merging this :)
| displayName: Download AOT offset files | ||
| inputs: | ||
| artifact: Mono_Offsets_Android | ||
| path: '$(Build.SourcesDirectory)/artifacts/obj/mono/offsetfiles' |
There was a problem hiding this comment.
do we still need this here if it's already in global-build-job.yml?
| - OSX_x64 | ||
| - Linux_x64 | ||
| jobParameters: | ||
| buildArgs: -s mono+libs+host+packs -c $(_BuildConfig) |
There was a problem hiding this comment.
do we really need the libs subset here?
| jobTemplate: /eng/pipelines/mono/templates/generate-offsets.yml | ||
| buildConfig: release | ||
| platforms: | ||
| - Android_x64 |
There was a problem hiding this comment.
maybe add a comment here that this will actually generate offsets for all platforms, not just x64.
| jobTemplate: /eng/pipelines/mono/templates/generate-offsets.yml | ||
| buildConfig: release | ||
| platforms: | ||
| - Android_x64 |
|
|
||
| # | ||
| # Build Mono release Android AOT cross-compiler | ||
| # Only when mono changed |
There was a problem hiding this comment.
| # Only when mono changed | |
| # Only when mono or installer changed |
|
|
||
| <PropertyGroup> | ||
| <MonoLibClang Condition="'$(MonoLibClang)' == ''">$(XcodeDir)/Toolchains/XcodeDefault.xctoolchain/usr/lib/libclang.dylib</MonoLibClang> | ||
| <MonoLibClang Condition="$([MSBuild]::IsOSPlatform('OSX')) and '$(MonoLibClang)' == ''">$(XcodeDir)/Toolchains/XcodeDefault.xctoolchain/usr/lib/libclang.dylib</MonoLibClang> |
There was a problem hiding this comment.
we should probably use the libclang.dylib from the ANDROID_NDK_ROOT here too instead of the one from xcode.
ghost
locked as resolved and limited conversation to collaborators
8 participants
--host=value (we must pass a--hosttriplet when we pass--target, and need to infer the correct one to use). This will cause CI failures until fixed, as we only build the runtime on Linux in CI.